1.20.6 merge #90
Merged
1.20.6 merge #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiles and runs, not heavily tested yet ItemStack "NBT" editing still works, even with components; component data is serialized to NBT for the NBT editor, and deserialized back to the stack if changes are made Arch FluidStack.empty() currently broken (returning null, causes crashes in fluid selection screens) Won't work with NeoForge 20.6.3-beta or later due to arch/neoforge mappings issues (see architectury/architectury-loom#207) No MinecraftForge support at all yet
Older arch network API is deprecated now
Fixes null empty fluid stacks and newest arch loom allows building with up-to-date NeoForge
Like NeoForgeExtraCodecs method, but we need it cross-platform...
20.6.50+ has API break causing architectury problems
items within a config group are now sorted alphabetically
The textbox now allows text which is considered invalid by the isValid() method, but will display it in red. Users of the textbox should check its validity with isTextValid() when deciding if the value should be committed.
Shift-click still adjusts selection pos, as expected FTBTeam/FTB-Mods-Issues#1185
also added javadocs for all the ConfigGroup add methods
Better support for any future menu-based screens
MichaelHillcox
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.20.6 port, for beta release