1.20.4/dev #92
Merged
1.20.4/dev #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code crashes because the FLUID_STACK type isn't registered with JEI The type needs to be registered, along with a helper and renderer and this doesn't feel worth it, given that we already have working support for native fluid types on all three platforms.
- PositionedIngredient must always use absolute screen coords for clicked areas - Fix handling of JEIIntegration#getClickableIngredientUnderMouse for fluidstacks on both Fabric and Forge
MichaelHillcox
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for JEI ingredient handling