Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Inventory article #246

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Block Inventory article #246

wants to merge 2 commits into from

Conversation

natri0
Copy link
Contributor

@natri0 natri0 commented Dec 30, 2024

Added an article about implementing Inventory in block entities. Some stuff (e.g. ImplementedInventory) copied over from wiki's "tutorial:inventory".

Tutorial covers using the ImplementedInventory & implementing SidedInventory, as well as some basic user interaction (inserting items on right-click).

Basically the same content as the article on the fabric wiki: https://wiki.fabricmc.net/tutorial:inventory

Uses the same `ImplementedInventory` class as that one to implement `Inventory` on the custom block entity
Maybe we should get a Checkstyle rule to allow comments after blocks? It's making me do stuff like this:

// :::1
if (condition) {
    // code...
}

// :::1

...which is IMO kinda ugly
@natri0 natri0 requested a review from a team as a code owner December 30, 2024 20:50
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 4dbf9a9
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6773077dc9d70a0008ff8085
😎 Deploy Preview https://deploy-preview-246--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11 IMB11 marked this pull request as draft December 30, 2024 20:52
@IMB11 IMB11 added new-content A new page or set of pages stage:verification This should be verified labels Dec 30, 2024
@its-miroma
Copy link
Member

Thank you for your contribution!

We are temporarily not accepting PRs until we finish the update process. Follow #242 for more information.

You may keep this PR open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages stage:verification This should be verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants