Update Mod Infra #25
Update Mod Infra #25
Conversation
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "org.scala-lang:scala3-library_3": "3.4.1" | |||
There was a problem hiding this comment.
There's only scala-library_3 to include? if so there's no reason for separate JSON. Just use the scala_version.txt.
There was a problem hiding this comment.
I wasn't sure why kotlin needed so many dependencies. Maybe scala needs more dependencies for it to work? I haven't actually set up a scala mod yet (lol) but I'm trying that out now so maybe I will find something that needs to be added.
There was a problem hiding this comment.
Well, it includes some common library that I'd argue should've been in the standard library.
On second thought, it's fine to do it this way, would make it easier if we do decide to include more modules.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "org.scala-lang:scala3-library_3": "3.4.1" | |||
There was a problem hiding this comment.
I don't think you should use a non-LTS version of Scala unless you can ensure that all versions of Scala (Scala3) can be released once.
Scala has a very unique compilation and loading mechanism, to the point where each revision in Scala2 is not compatible with each other.
The Long-term compatibility plans for Scala 3 figured out that:
The Scala 3 version that you are using to compile your code should be treated the same way as any library dependency in your project. You shouldn’t be afraid of updating it. Bumping the patch version (e.g. 3.1.2 -> 3.1.3) is a no-brainer. Bumping the minor version (e.g. 3.1.3 -> 3.2.0) requires the same considerations as changing the minor version of any other dependency, yet is generally advisable.
You should not cross-compile between Scala 3 versions.
So I think that choose LTS version of Scala3 will be better.
What about Scala2? Let it go, it's time to vanish.
|
Just FYI I moved on to using https://github.com/Kotori316/SLP-fabric since it seems way more mature as a project. |
As mentioned in #22
This PR simply copies the repo style from https://github.com/FabricMC/fabric-language-kotlin
Admins will need to configure the GH secrets for this repo (and test GH actions)
This was a pretty brain-dead operation so apologies for large PR