-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NumberInput.looksLikeValidNumber()
implementation
#1241
Conversation
Thanks for dealing with this topic :D It seems that we're encountering this error because the prevalidation method looksLikeValidNumber is misplaced for the given input, which is JSON-Type string and not number. |
NumberInput.looksLikeValidNumber()
implementation
(I thought I had added a comment here). No. this cannot and should not be removed: while the location of method may be misplaced (it is really only needed by Thank you @pjfanning for PR, will merge to get in 2.17.1 |
See FasterXML/jackson-databind#4435
I'm not a regex expert and sort of hate them from a code readability and maintenance perspective.
This is my attempt at fixing the issue but the method is now so neutered, I really wonder if the method should be removed. It is also going to cause perf issues as the check is non-trivial.