Do not rewind position when serializing direct ByteBuffer
#4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteBufferSerializer considers the position when serializing heap buffers, but ignores it (by rewinding) for direct buffers. I believe the former behavior is correct, so I've aligned the direct buffer code with that. This might be better for 2.17, I don't know.
JooHyukKim
reviewed
Oct 17, 2023
src/main/java/com/fasterxml/jackson/databind/ser/std/ByteBufferSerializer.java
Outdated
Show resolved
Hide resolved
cowtowncoder
approved these changes
Oct 17, 2023
cowtowncoder
changed the title
position when serializing direct ByteBuffer
|
Makes sense to me: thank you @yawkat. And while there is some risk here, I think this belongs in 2.16 since we are pre-release-candidate phase. |
cowtowncoder
added a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteBufferSerializer considers the position when serializing heap buffers, but ignores it (by rewinding) for direct buffers. I believe the former behavior is correct, so I've aligned the direct buffer code with that.
This might be better for 2.17, I don't know.
testByteBufferwas broken by this change because it didn't flip the buffer after writing.