Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 432: Wrap additional AssertionError from IonReader #433

Merged
merged 6 commits into from
Dec 30, 2023

Conversation

arthurscchan
Copy link
Contributor

This PR fixes #432 by wrapping the unexpected AssertionError with the general JsonParseException to avoid throwing AssertionError directly to the users when invalid input is provided.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@cowtowncoder cowtowncoder merged commit 80ae368 into FasterXML:2.17 Dec 30, 2023
4 checks passed
@cowtowncoder
Copy link
Member

Thank you @arthurscchan !

@cowtowncoder cowtowncoder added this to the 2.17.0 milestone Dec 30, 2023
@cowtowncoder cowtowncoder added the fuzz Issue found by OssFuzz label Dec 30, 2023
@arthurscchan arthurscchan deleted the 432-fix branch January 17, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzz Issue found by OssFuzz ion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More methods from IonReader could throw an unexpected AssertionError
2 participants