Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fix-mobile-icon): on mobile, custom rules doesn't load at startup #624

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Mara-Li
Copy link
Contributor

@Mara-Li Mara-Li commented Dec 3, 2024

See #617
It fixes the error at startup when loading the rules on mobile.

Probably a not good fix, but it works, at last.

Close #617

Note

I needed to change the package json because pnpm run lint throw an error:

Oops! Something went wrong! :(

ESLint: 8.57.1

No files matching the pattern "'*/**/*.{js,ts,tsx}'" were found.
Please check for typing mistakes in the pattern.

Removing the ' around the pattern fix the things.
Maybe switching to @biomejs will be a good thing to remove dep?

@FlorianWoelki
Copy link
Owner

Thank you for the PR!

@FlorianWoelki FlorianWoelki merged commit d255b5b into FlorianWoelki:main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruled icon on mobile doesn't works
2 participants