Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field: change signature of group raise_event #666

Merged
merged 3 commits into from
Nov 22, 2024
Merged

field: change signature of group raise_event #666

merged 3 commits into from
Nov 22, 2024

Conversation

salix5
Copy link
Collaborator

@salix5 salix5 commented Nov 21, 2024

void raise_event(card* event_card, uint32 event_code, effect* reason_effect, uint32 reason, uint8 reason_player, uint8 event_player, uint32 event_value);
void raise_event(const card_set& event_cards, uint32 event_code, effect* reason_effect, uint32 reason, uint8 reason_player, uint8 event_player, uint32 event_value);

Now group version of raise_event use a const reference.
The overload resolution will not fail when the first parameter is nullptr.

group版本的raise_event改成使用const reference
現在第一個參數傳入nullptr時2個重載版本不再會混淆

@mercury233
@purerosefallen
@Wind2009-Louse
@fallenstardust

@salix5 salix5 merged commit 94dcb8a into master Nov 22, 2024
1 check passed
@salix5 salix5 deleted the patch1 branch November 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant