Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new functions #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new functions #2

wants to merge 2 commits into from

Conversation

eminetto
Copy link

@eminetto eminetto commented Oct 3, 2018

No description provided.

@eminetto eminetto mentioned this pull request Oct 3, 2018
Copy link
Owner

@FrenchBen FrenchBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the ability to retain our debugging for this package.
Ideally we should have:

  • More debugging
  • Tests 👼

client.go Show resolved Hide resolved
@FrenchBen
Copy link
Owner

If anything, it'd be good to see tests associated with your latest function addition. (don't want you to take on the whole thing)

@@ -0,0 +1,56 @@
package godisco
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP :)

@@ -0,0 +1,15 @@
package godisco
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP :)

@FrenchBen FrenchBen added the WIP label Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants