-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add text imports #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment looks good to me otherwise! Nice job on this
Let Them Cook 🔥 Semantic importsLFG plugins for remak that can extract sections of other documents delimited by comment-names. This comment-name is a semantic key that links multiple components to import, parse, render and test, Code Importskey: 'install_fuelup_command'
Text importskey: install_fuelup
Test actionskey: ?
Some ideasSnippet importA pattern emerges: the code snippet component might be not only a render component but a whole syntax.
That gets resolved to:
Then, the installation guide might look like:
Can be applied in the installation section of the quickstart as well. It feels to me like a natural step towards something similar to the 🥳🥳🥳 It's very exciting to see how this whole docs effort evolves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job here!
This is amazing.
I think the docs-hub is getting to a stage where it needs to be documented.
👽 Documenting the documentation.
Thanks, I agree, we should add this to the README. The TestAction actions are documented in the tests/utils/types.ts file btw. Also, I like your idea about combining snippets, I'll add that to the backlog as well. |
adds the ability to import text between guides, cleans up the code import plugin, and pulls in installation instructions into the quickstart from the installation guide