Show error when contract method names conflict

[xunilrj]

Description

Today, contract call uses the method name to identify which contract method to call. That means that a contract cannot have multiple methods with the same name.

That can happen when a contract implements traits:

A lot of the lifetime changes were caused by clippy.

Checklist

• I have linked to any relevant issues.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • If my change requires substantial documentation changes, I have requested support from the DevRel team
• I have added tests that prove my fix is effective or that my feature works.
• I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
• I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
• I have requested a review from the relevant team or maintainers.

[codspeed-hq]

CodSpeed Performance Report

Merging #6782 will not alter performance

_{Comparing xunilrj/error-contract-method-conflict (fedeb56) with master (4fe6870)}

Summary

✅ 22 untouched benchmarks

[sdankel]

LGTM, just one nit

[sdankel]

Actually, I noticed that the new errors aren't being passed to LSP. You can test this by installing forc-plugins/forc-lsp and loading the test file in VSCode. The new errors do not show up in the editor. I'm still digging into it, but it looks like the errors aren't being emitted to the handler properly. When I log the handler at the end of sway-core/src/lib.rs parsed_to_ast, the errors vec is empty.

[xunilrj]

This happens because the LSP still compiles everything using encoding v0, and this check only runs for encoding v1. See https://github.com/FuelLabs/sway/blob/master/sway-lsp/src/core/session.rs#L323.

It used to be the case that LSP was not compatible with encoding v1. I am not sure this is still true.

[tritao]

Looks good (aside from the nit from @sdankel)

[xunilrj]

When I enable the LSP to use encoding V1 (just removing from the no_experimental in session.rs), I see the diagnostic inside traverse. But typed at line 395, is Err(...), which I think is short-circuiting the processing of all the others diagnostics, and nothing is returned.

[xunilrj]

I managed to improve what the compiler sends to the LSP server, and now the error is being displayed correctly.

[xunilrj]

I have rollbacked part of the solution to enable encoding v1 in the LSP. The issue is a problem with the garbage collector. However, I am pushing the solution to improve how the LSP deals with compiler errors.

This means that when the compiler fails, it returns as much information as possible to the LSP server. Which is also using as much information as it can to enrich data for tokens.

In general, LSP should be able to show more diagnostics now. But unfortunately, it will not show the errors of this PR.

[sdankel]

🚀

[JoshuaBatty]

Nice work @xunilrj , just a couple of small nits.