Add splice method to Bytes #6823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the addition of splice, but I think we should match Rust's Vec impl https://doc.rust-lang.org/std/vec/struct.Vec.html#method.splice by taking a second optional param replace_with |
xunilrj
reviewed
Jan 13, 2025
| if splice_len != replace_with.len() && tail_len > 0 { | ||
| let src = self.buf.ptr().add_uint_offset(end); | ||
| let dst = self.buf.ptr().add_uint_offset(start + replace_with.len()); | ||
| // Use temporary buffer to safely handle overlapping memory |
There was a problem hiding this comment.
Do you need this temp if you read [end..] from the original buffer? I think you don´t, and you could save this temp copy.
jjcnn
requested changes
Jan 14, 2025
Comment on lines
+170
to
+186
| #[test()] | ||
| fn bytes_splice_replace_empty_bytes() { | ||
| let (mut bytes, a, b, c) = setup(); | ||
| // bytes = [5, 7, 9] | ||
| let replacement = Bytes::new(); | ||
| // Remove [0..1) => [5], replace with [] | ||
| let spliced = bytes.splice(0, 1, replacement); | ||
|
|
||
| // bytes => [7, 9] | ||
| assert(bytes.len() == 2); | ||
| assert(bytes.get(0).unwrap() == b); | ||
| assert(bytes.get(1).unwrap() == c); | ||
|
|
||
| // spliced => [5] | ||
| assert(spliced.len() == 1); | ||
| assert(spliced.get(0).unwrap() == a); | ||
| } |
There was a problem hiding this comment.
This case additonally tests one of the situations where the end of the original buffer overlaps with the end of the new buffer, i.e., the case where you need the temporary buffer.
As a regression test you should probably add a test for the other case, i.e,
// bytes = [5, 7, 9]
// Remove [0..1] => [5], replace with [10, 12]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a splice method to bytes that lets you select start and end indices, and returns the range of bytes, removing them from the original bytes.
Checklist
Breaking*orNew Featurelabels where relevant.