Fix DialectContext destructor

It ended up destructing the extension pointers multiple times. Interestingly, this crashed on Windows before it did on Linux.
GPUOpen-Drivers · Jan 4, 2024 · 8fca758 · 8fca758
1 parent bc5d060
commit 8fca758
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/Dialect/Dialect.cpp b/lib/Dialect/Dialect.cpp
@@ -194,8 +194,7 @@ DialectContext::~DialectContext() {
 
   std::unique_ptr<ContextExtensionBase> *extensionArray =
       getTrailingObjects<std::unique_ptr<ContextExtensionBase>>();
-  for (unsigned i = 0; i < m_extensionArraySize; ++i)
-    std::destroy_n(extensionArray, m_extensionArraySize);
+  std::destroy_n(extensionArray, m_extensionArraySize);
 
   Dialect **dialectArray = getTrailingObjects<Dialect *>();
   for (unsigned i = 0; i < m_dialectArraySize; ++i)