Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArgumentIndex enum #114

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Use ArgumentIndex enum #114

merged 3 commits into from
Dec 4, 2024

Conversation

tsymalla
Copy link
Contributor

@tsymalla tsymalla commented Dec 3, 2024

Instead of inserting the index value, use the enum value from ArgumentIndex.

Use ArgumentIndex enum
baabbc4 
Instead of inserting the index value, use the enum value from
ArgumentIndex.
@tsymalla-AMD tsymalla-AMD requested a review from Flakebi December 3, 2024 13:27
Flakebi
Flakebi reviewed Dec 4, 2024
View reviewed changes
lib/TableGen/Operations.cpp Outdated Show resolved Hide resolved
lib/TableGen/Operations.cpp Outdated Show resolved Hide resolved
Flakebi
Flakebi approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsymalla-AMD tsymalla-AMD merged commit 87a0bea into GPUOpen-Drivers:dev Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasilvanus jasilvanus jasilvanus left review comments

@Flakebi Flakebi Flakebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsymalla @Flakebi @jasilvanus @tsymalla-AMD