Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Visitor more robust on instruction iteration #79

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Make Visitor more robust on instruction iteration #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/Dialect/Visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,12 @@ void VisitorBase::visit(void *payload, Function &fn) const {
if (m_strategy == VisitorStrategy::ReversePostOrder) {
ReversePostOrderTraversal<Function *> rpot(&fn);
for (BasicBlock *bb : rpot) {
for (Instruction &inst : make_early_inc_range(*bb))
visit(payload, inst);
// Allow callbacks to directly edit the code adding basic blocks
for (Instruction *inst = &*bb->begin(); inst != nullptr;) {
auto nextInst = inst->getNextNode();
visit(payload, *inst);
inst = nextInst;
}
}
return;
}
Expand Down
Loading