Change name mangling for intrinsic functions fixing #2 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanRehders-AMD
force-pushed
the
amd/dev/jrehders/name-mangling
branch
from
4b8297d to
aee3634
Compare
tsymalla
reviewed
Feb 1, 2024
We want to avoid confusion when one op's intrinsic is the prefix of another one. Using a character which we don't use for intrinsic function names ensures this. Fixes GPUOpen-Drivers#2
JanRehders-AMD
force-pushed
the
amd/dev/jrehders/name-mangling
branch
from
aee3634 to
d93eb58
Compare
nhaehnle
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid confusion when one op's intrinsic is the prefix of another one. Using a string
__which we don't use for intrinsic function names ensures this. Using "$" was considered but__was chosen so the LLVM IR printer will not add quotes to those names which would make updating the tests much harder.