Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing CR in test-generated.ll. #85

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tsymalla
Copy link
Contributor

@tsymalla tsymalla commented Feb 1, 2024

Add the option strip-trailing-cr to avoid CR/LF-related test failures. The dialect files are created with LF, thus we don't want to see diff mismatches in git environments which check out with CRLF.

Add the option `strip-trailing-cr` to avoid CR/LF-related test failures.
The dialect files are created with LF, thus we don't want to see diff
mismatches in git environments which check out with CRLF.
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@tsymalla-AMD tsymalla-AMD merged commit 8640583 into GPUOpen-Drivers:dev Feb 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants