Skip to content

Commit

Permalink
Merge pull request #62 from GPUOpen-LibrariesAndSDKs/precomp-submodule
Browse files Browse the repository at this point in the history
Precomp submodule
  • Loading branch information
RichardGe authored Mar 20, 2023
2 parents 2a4633c + c328f0a commit 251787e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "hipbin"]
path = hipbin
url = https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderSDKKernels
1 change: 1 addition & 0 deletions hipbin
Submodule hipbin added at a222c3
9 changes: 3 additions & 6 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,11 @@ This repo contains :
## Install Precompiled Kernels

Since 3.01.00, for Northstar the default render backend is HIP ( instead of OpenCL ). \
The main difference is that compute kernels are now precompiled by us. They must be downloaded from a separate link.\
The main difference is that compute kernels are now precompiled by us. They must be downloaded from a submodule.\
Note that for now you can still use the OpenCL backend ( with `RPR_CREATION_FLAGS_ENABLE_OPENCL` in `rprCreateContext` ). However we don't recommend it as in the future we may put less resource to support this backend.\
Download the precompiled kernels here: https://www.dropbox.com/s/uojh957rxcvrc6b/hipbin_3.01.00.zip?dl=0 \
In order to run tutorials, it's recommended to put the package inside tutorials/Bin/ so that it looks like that:
Download the precompiled kernels with the command:
```
tutorials/Bin/hipbin/AllPreCompilations.json
tutorials/Bin/hipbin/****.hipbin
tutorials/Bin/hipbin/****.cudabin
git submodule update --init --recursive
```

The precompiled kernels folder can be modified with `RPR_CONTEXT_PRECOMPILED_BINARY_PATH`. ( for its usage, check the tutorials ).
Expand Down
4 changes: 2 additions & 2 deletions tutorials/common/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ const rpr_context_properties g_contextProperties[] =
{

// define the precompiled kernels folder.
// for most of the tutorials, the path will be <working directory>/hipbin/*****.hipbin
// for most of the tutorials, the path will be <working directory>../../hipbin/*****.hipbin
// ( check the readme for more information about precompiled kernels )
(rpr_context_properties)RPR_CONTEXT_PRECOMPILED_BINARY_PATH,
(rpr_context_properties)"hipbin",
(rpr_context_properties)"../../hipbin",

// terminate the list of properties with a NULL <property name>
(rpr_context_properties)0,
Expand Down

0 comments on commit 251787e

Please sign in to comment.