Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chemical Bath + Thermal Centrifuge mode to IOF #3539

Merged
merged 7 commits into from
Dec 22, 2024

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Nov 23, 2024

Closes #17067

@Nockyx Nockyx marked this pull request as draft November 23, 2024 04:01
@CookieBrigade CookieBrigade added enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. labels Nov 23, 2024
@Nockyx Nockyx marked this pull request as ready for review November 23, 2024 20:25
@HoleFish
Copy link
Contributor

have you tested how this mode works with stocking hatch?

@Dream-Master Dream-Master requested a review from a team November 24, 2024 10:04
@Nockyx
Copy link
Contributor Author

Nockyx commented Nov 24, 2024

have you tested how this mode works with stocking hatch?

no, i tested only with normal hatch, i'll test it with stocking too later

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@RecursivePineapple
Copy link
Contributor

@Nockyx Have you tested this with stocking hatches yet? Not sure if you've gotten around to it since it was frozen for a while.

@Nockyx
Copy link
Contributor Author

Nockyx commented Dec 22, 2024

tested using both stocking bus and hatches.

behaviour using each of the possible fluids on an ore that can accept both
image

behaviour while having both stocked, it prioritizes the mercury process
image

otherwise the consumption is working as expected and isn't causing a dupe or running with both fluid at once creating extra outputs

@serenibyss serenibyss enabled auto-merge (squash) December 22, 2024 01:30
@serenibyss serenibyss merged commit d4387ea into GTNewHorizons:master Dec 22, 2024
5 checks passed
@Nockyx Nockyx deleted the iof-mode branch December 26, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new mode to IOF
6 participants