Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boldarnator (industrial rock breaker) GPL #3668

Merged
merged 13 commits into from
Dec 26, 2024
Merged

Boldarnator (industrial rock breaker) GPL #3668

merged 13 commits into from
Dec 26, 2024

Conversation

HoleFish
Copy link
Contributor

@HoleFish HoleFish commented Dec 18, 2024 •
edited
Loading

  • Under GPL, Boldarnator gets subtick
  • Boldarnator parallel and speed bonus are removed, instead it gains perfect overclocks
  • Boldarnator will get programmed circuit from input bus now

@HoleFish HoleFish added refactor For PRs rewritting a part of the code to have a nicer code overall. Affects Balance Change affecting balance. Requires admin approval before merging. labels Dec 18, 2024
@HoleFish HoleFish requested a review from a team December 18, 2024 19:01
@HoleFish HoleFish changed the title Boldarnator GPL&Buff Boldarnator (industrial rock breaker) GPL&Buff Dec 18, 2024
@serenibyss
Copy link
Member

serenibyss commented Dec 18, 2024 •
edited
Loading

Note: whichever merges first second between this and #3305 will need to make sure to set .allowCircuitOnly(true) on the multi rock breaker recipe map

@Dream-Master Dream-Master requested a review from a team December 19, 2024 19:42
serenibyss
serenibyss approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, I will leave it open for now for anyone else to comment on the balance change (I think the buff is warranted personally)

@chochem
Copy link
Member

chochem commented Dec 21, 2024

regarding balance, the multi was certainly always good as is. I certainly didnt have any issues when I used. The problem is more that other buffs to the pack outscaled it.

serenibyss
serenibyss requested changes Dec 21, 2024
View reviewed changes
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HoleFish Sorry for the conflicting back to back reviews, but after discussing some more we decided that the buff should be a bit more of a compromise than perfect OC

...us/xmod/gregtech/common/tileentities/machines/multi/production/MTEIndustrialRockBreaker.java Outdated Show resolved Hide resolved
@HoleFish HoleFish changed the title Boldarnator (industrial rock breaker) GPL&Buff Boldarnator (industrial rock breaker) GPL Dec 25, 2024
@HoleFish HoleFish added bug fix Fix a bug. Please link it in the PR. and removed Affects Balance Change affecting balance. Requires admin approval before merging. labels Dec 25, 2024
@serenibyss serenibyss enabled auto-merge (squash) December 26, 2024 01:50
@serenibyss serenibyss merged commit bb18163 into GTNewHorizons:master Dec 26, 2024
5 checks passed
@HoleFish HoleFish deleted the buff branch December 27, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR. refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HoleFish @serenibyss @chochem @Dream-Master