Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiered solar generators to gt #3689

Merged
merged 14 commits into from
Dec 22, 2024
Merged

Add tiered solar generators to gt #3689

merged 14 commits into from
Dec 22, 2024

Conversation

FourIsTheNumber
Copy link
Contributor

Adds LV through UV fullblock solar panels. Each outputs 1A of its tier and stores 10000 * tier eu. They do not operate at night (duh), while covered, or during rain (if the biome has rain). They do not explode in rain.

image

The point of these panels is to replace the existing ones added by Advanced Solar Panels and Super Solar Panels, with a few perks.

  • Direct GT integration
  • Same output and storage capacity
  • Properly function with enet, since they are GT instead of a different ic2 addon
  • Push towards removing these mods (Advanced Solar Panels is ARR and reliant on ic2, which we want to remove)

For now, these have no recipes, but would ideally just be swapped in place of the recipes from the addons (with a conversion recipe). I do not want to try and postea this, since these panels have a sided output. In the future, the crafting items from advanced solar panels should be redone with new names/textures and added to gt or dreamcraft.

@FourIsTheNumber FourIsTheNumber added the new feature Add something new. Please explain in detail how it works. label Dec 22, 2024
@Reflex18
Copy link
Contributor

I mean... the other solars had unique and pretty textures on them

@FourIsTheNumber
Copy link
Contributor Author

I mean... the other solars had unique and pretty textures on them

Sure. And someone can make textures for these if they want, since it's in a mod we control. I can't legally take the textures from there, but now they're modifiable.

@FourIsTheNumber
Copy link
Contributor Author

Also, pretty textures doesn't save you from being unusable due to shoddy enet connection.

@Reflex18
Copy link
Contributor

I mean... the other solars had unique and pretty textures on them

Sure. And someone can make textures for these if they want, since it's in a mod we control. I can't legally take the textures from there, but now they're modifiable.

Thats great, It has the option to be changed by anyone and the options to any additions to solars in the future.

@chochem
Copy link
Member

chochem commented Dec 22, 2024

I mean the existings ones work flawlessly with enet, I played a techsolar run to luv without a single issue. Really no idea what you are talking about.
But since some of that is ARR a replacement is awesome anyway!

I don't think it needs postea yea. Just conversion recipe and keeping the old ones for one major patch sounds good. Maybe ill continue my run :P

@FourIsTheNumber
Copy link
Contributor Author

I mean the existings ones work flawlessly with enet, I played a techsolar run to luv without a single issue. Really no idea what you are talking about. But since some of that is ARR a replacement is awesome anyway!

I had them break on me constantly 😭 had to reconnect them every day. Maybe it got better since then or I was doing something weird

@boubou19
Copy link
Member

as someone who used them for years, yeah they were working well. But we cannot just yeet advanced solar panels/ super solar panels as we use some of their items in some crafts. So i'd say we just yeet the solar recipes and add conversion recipes. What was nice with those was to avoid cleaning up the solars every once in a while. Will those new solars work the same?

@FourIsTheNumber
Copy link
Contributor Author

FourIsTheNumber commented Dec 22, 2024

Will those new solars work the same?

Yeah, same as before, they don't have the cleaning mechanic that the covers do.

@Dream-Master
Copy link
Member

Dream-Master commented Dec 22, 2024

Will those new solars work the same?

Yeah, same as before, they don't have the cleaning mechanic that the covers do.

the blocks haven't the cleaning mechanism as well. (from adv Solar panel mod)

@Dream-Master Dream-Master requested a review from a team December 22, 2024 11:14
@Dream-Master Dream-Master requested a review from a team December 22, 2024 22:33
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks great, will need a follow-up PR for recipes for the machines and conversion recipes from the old full-block solar panels

@Dream-Master Dream-Master merged commit 8a15c91 into master Dec 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants