Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT++ multiblock glow texture support #3704

Merged
merged 7 commits into from
Dec 26, 2024

Conversation

serenibyss
Copy link
Member

Glow texture support for GT++ multiblocks
image

Skipped LPF since it is deprecated, otherwise all applicable multiblocks are covered

@serenibyss serenibyss requested a review from a team December 24, 2024 18:06
@serenibyss serenibyss added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Dec 24, 2024
@serenibyss serenibyss changed the title Gtppmultiblockbase glow support GT++ multiblock glow texture support Dec 24, 2024
Copy link
Contributor

@leagris leagris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations and thank you for implementing this into GTpp.
I didi not test it, although as far as I know, the code looks ok.
Happy Santa! 🎅 🎉

@Dream-Master Dream-Master requested a review from a team December 24, 2024 19:16
Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work for me

@Dream-Master Dream-Master enabled auto-merge (squash) December 26, 2024 21:12
@Dream-Master Dream-Master merged commit 569c3ee into master Dec 26, 2024
5 checks passed
@Dream-Master Dream-Master deleted the gtppmultiblockbase-glow-support branch December 26, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants