Fix crash when right clicking howler with any gtmetaitem #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: 2 uncommitted changes |
…ixes Spotless apply for branch fix-howler-crash for #19
OneEyeMaker
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash happens because some gtmetaitems are oredicted as dyes which apparently causes oredict to think all of them are.
The problem arises when NC tries to verify that its the correct item since someone decided to return -1 as the dye id if the item damage doesn't match which in turn causes the AIOOBE. (They even left a nice comment recognizing that it would cause issues)
Closes GTNewHorizons/GT-New-Horizons-Modpack#15986