Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE2: Added a faster method to filter items from ME network #125

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Georggi
Copy link

@Georggi Georggi commented Jun 28, 2024

This function allows to filter only by numerical and string IDs, but causes 0 lag spike, unlike getItemsInNetwork, which is insanely slow on any normal size ME network.

Better name suggestions are appreciated.

@Georggi Georggi force-pushed the addFasterAENetworkAccess branch from 760bd6d to a039312 Compare June 28, 2024 13:44
@Georggi
Copy link
Author

Georggi commented Jun 28, 2024

Renamed function to getItemsInNetworkById for now

@Dream-Master Dream-Master requested a review from a team June 28, 2024 15:26
@Georggi
Copy link
Author

Georggi commented Jun 28, 2024

Might be a good idea to do the same for getCraftables?
These 2 methods would allow for a simpler filter by a list of string or numerical IDs and do convert() later. But may require additional filtering inside Lua.
When you work with 1 item old method might be fine, but when you want to handle multiple items, you are kind of limited by needing to call getItemsInNetwork for each item.

@Dream-Master Dream-Master merged commit 6b9b22c into GTNewHorizons:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants