Slider: make screen readers recognize correctly #4212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grgr-dkrk is attempting to deploy a commit to the Geekyants Team Team on Vercel. A member of the Team first needs to authorize it. |
grgr-dkrk
commented
Oct 18, 2021
Comment on lines
74
to
79
| <Box | ||
| accessible | ||
| {...inputProps} | ||
| position="absolute" | ||
| {...thumbProps} | ||
| {...resolvedProps} | ||
| ref={ref} | ||
| style={[thumbStyles, props.style]} | ||
| // {...(isReadOnly && _readOnly)} | ||
| // {...(isDisabled && _disabled)} | ||
| pointerEvents="box-none" | ||
| style={styles.wrapper} |
There was a problem hiding this comment.
Even though the SliderThumb component is accessible, it only focuses on circles. This is inconvenient because the focus range is narrowed during the drag operation.
Therefore, add an accessible wrapper that is the same width as the SliderTrack on top of the SliderThumb.
I've also set pointer-events so that the Pressable below can still be tapped (or clicked on web).
grgr-dkrk
changed the title
grgr-dkrk
force-pushed
the
fix/slider-a11y
branch
from
1d226d9 to
e800ba1
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since
SliderTrackis Pressable, screen readers focus on SliderTrack instead of SliderThumb. However, SliderTrack has no control over slider values.This PR connects react-native-aria's inputProps to SliderThumb and allows screen readers to access the slider.
In addition to this PR, the issue also need to fix GeekyAnts/react-native-aria#23 due to a bug in the behavior of react-native-aria.
Changelog
[General] [Fixed] - Allow screen readers to correctly recognize the state of Slider components
Test Plan
Android: Before
slider-a11y-android1.mp4
Android: Fixed
slider-a11y-android0.mp4
iOS: Before
slider-a11y-ios1.mp4
iOS: Fixed
slider-a11y-ios0.mp4