Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 💥 Allow creating multiple instances of app containers #1788

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

CLHatch
Copy link
Contributor

@CLHatch CLHatch commented Sep 18, 2024

Pull request

Purpose
Allow creating multiple instances of built-in apps without using an override.

Approach
Replace all references of the app's name in templates in .apps to $(appname} and ${APPNAME}.
On run, copy the folders of apps being used to .instances, using folder names similar to below.:

.instances/radarr
.instances/radarr__radarr4k

The "appname" variables in the files in these folders will be replaced by the folder name.

We will then use the .instances folder insstead of the .apps folders when creating the .env file.

Open Questions and Pre-Merge TODOs
Check all boxes as they are completed

  • Use github checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem

Requirements
Check all boxes as they are completed

@github-actions github-actions bot added apps Automatic label docs Automatic label labels Sep 18, 2024
@CLHatch CLHatch marked this pull request as ready for review September 18, 2024 00:31
@CLHatch CLHatch requested review from a team as code owners September 18, 2024 00:31
@CLHatch CLHatch merged commit e615f6b into GhostWriters:multi-instance Sep 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps Automatic label docs Automatic label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant