Skip to content

Commit

Permalink
Remove unnecessary tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Hartorn committed Oct 31, 2023
1 parent 9130b3a commit 9efbce1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions giskard/testing/tests/performance.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,11 @@ def _test_diff_prediction(
" reference_dataset is equal to zero"
)

if direction == Direction.Invariant or direction == Direction.Invariant.value:
if direction == Direction.Invariant:
passed = abs(rel_change) < threshold
elif direction == Direction.Decreasing or direction == Direction.Decreasing.value:
elif direction == Direction.Decreasing:
passed = rel_change < threshold
elif direction == Direction.Increasing or direction == Direction.Increasing.value:
elif direction == Direction.Increasing:
passed = rel_change > threshold
else:
raise ValueError(f"Invalid direction: {direction}")
Expand Down

0 comments on commit 9efbce1

Please sign in to comment.