-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-3948] Add numerical perturbation detector #2094
Open
henchaves
wants to merge
33
commits into
main
Choose a base branch
from
feature/gsk-3948-add-numerical-perturbation-detector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[GSK-3948] Add numerical perturbation detector #2094
henchaves
wants to merge
33
commits into
main
from
feature/gsk-3948-add-numerical-perturbation-detector
+433
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matteo <me@mattbit.com>
Co-authored-by: Matteo <me@mattbit.com>
Co-authored-by: Matteo <me@mattbit.com>
Co-authored-by: Matteo <me@mattbit.com>
Hey @Kranium2002, I closed the old PR (#2040) and opened this new one because I was not being able to format the files |
henchaves
changed the title
Feature/gsk 3948 add numerical perturbation detector
[GSK-3948] Add numerical perturbation detector
Jan 6, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the numerical perturbation detector feature to robustness detector. This PR is still a work in progress.
The detector will perturb the values by 1 percent and then check for errors in classification mode and for regression the model flags any error which is 5% away from the real value. This could be made so that the user can adjust these percentages but for now this is fixed. Review needed on this.
Disclaimer: This is a new PR replacing #2040, which was opened and implemented by @Kranium2002.
Related Issue
#1846
Type of Change