Reintro vertical table lines + hover state #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06076e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
viktorrenkema
commented
Dec 20, 2024
| } | ||
|
|
||
| :global(.dark) .columnHeader { | ||
| @apply text-white; | ||
| } | ||
|
|
||
| .row { | ||
| @apply flex border-tint-700/2; | ||
| @apply flex border-tint-700/2 hover:bg-tint-700/2 transition-colors; |
There was a problem hiding this comment.
Ideally I'd apply hover:bg-tint-700/1 dark:hover:bg-tint-700/2 so the dark mode hover color is different than the light-mode, but tailwind doesn't agree. Open to suggestions, otherwise ill look into it later and fix after.
emmerich
approved these changes
Dec 20, 2024
viktorrenkema
force-pushed
the
viktor/restore-table-lines
branch
3 times, most recently
from
21265c1 to
18e79f5
Compare
viktorrenkema
force-pushed
the
viktor/restore-table-lines
branch
from
18e79f5 to
482a0a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked with @zenoachtig
After
CleanShot.2024-12-19.at.09.54.29.mp4