Complete the stepping stone #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannou
commented
May 22, 2024
| { | ||
| "Authorization": "Bearer #{ @options[:bearer_token]&.call }", | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Rhino will then use it like so:
ActiveShipping::UPS.new(
key: "poo",
login: "pee",
password: "poopie",
bearer_token: -> { Setting.find_by( key: :ups_bearer_token ).value },
)
|
The other side: |
|
@mjcbsn22 Come this way too! |
|
Don't worry, I won't merge this until https://app.circleci.com/pipelines/github/Goldbely/rhino/1484/workflows/3c1755b6-a6d7-4540-aa4d-d8ecfebd9339 is done deploying |
mjcbsn22
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5 shouldn't have been merged into master, coz it makes master broken, and could've made Rhino broken, if Rhino accidentally updates ActiveShipping.
This completes the stepping stone implementation, so that Rhino can then update ActiveShipping.