Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add filters in full report file #770

Merged
merged 29 commits into from
Jul 24, 2024
Merged

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Jul 23, 2024

Description

This PR updates callbacks handling data passing to report.html, updates the useGlobalFiltering hook handling filters, and passes filter values to the useFiltering hook.

Relevant Technical Choices

  • Pass the selected filters object to the appliedFilters key inside the PSAT_DATA object.
  • The useGlobalFiltering hook will parse filter values from globalThis.PSAT_DATA.appliedFilters and select the ones present.

Testing Instructions

  • Open Extension, apply filters, and download the report from the landing page.
  • The filters should be present in the downloaded report.
  • Now update the filters and download the report again.
  • The zip file should be downloaded and report.html should have updated filters applied.
  • Now try same on sitemap and single URL inside CLI.

Additional Information:

Few minor issues found not related to the issue

  • Added loader for the report download button.
  • Memoize the clearQuery callback for fewer rerenders.
  • Update keys for exemption cookies and exemption reasons translations.
  • Landing page scrolling not updating the menu bar.

Screenshot/Screencast

Screenshot 2024-07-23 at 17 23 37

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 changed the title Add filters in full report file Enhancement: Add filters in full report file Jul 23, 2024
Base automatically changed from fix/report-generation to develop July 24, 2024 09:28
@mayan-000 mayan-000 requested review from mohdsayed and amovar18 July 24, 2024 09:51
@mayan-000 mayan-000 marked this pull request as ready for review July 24, 2024 09:51
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jul 24, 2024
@mohdsayed mohdsayed merged commit b071b4a into develop Jul 24, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/filters-in-report branch July 24, 2024 12:34
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants