Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: QA issues #789

Merged
merged 23 commits into from
Jul 30, 2024
Merged

Fix: QA issues #789

merged 23 commits into from
Jul 30, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jul 29, 2024

Description

This PR aims to fix all the QA build errors that were reported.
This fixes the following QA issues:

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #768

@amovar18 amovar18 self-assigned this Jul 29, 2024
@amovar18 amovar18 marked this pull request as ready for review July 29, 2024 09:21
@amovar18 amovar18 requested review from mohdsayed and mayan-000 July 29, 2024 09:22
@amovar18 amovar18 marked this pull request as draft July 29, 2024 10:26
@amovar18 amovar18 changed the title Fix: QA build errors Fix: QA issues Jul 29, 2024
@amovar18 amovar18 marked this pull request as ready for review July 30, 2024 08:05
@amovar18 amovar18 requested a review from mohdsayed July 30, 2024 08:05
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mohdsayed mohdsayed added this to the v0.10 milestone Jul 30, 2024
@mohdsayed mohdsayed merged commit a477a7f into develop Jul 30, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/build-errors branch July 30, 2024 08:25
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants