Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add tables to PA EE #888

Merged
merged 34 commits into from
Dec 20, 2024
Merged

Feature: Add tables to PA EE #888

merged 34 commits into from
Dec 20, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Dec 11, 2024 •
edited
Loading

Description

This PR adds tables to display interest group and auction config to the explorable explanation tab.

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run build:ext.
  • Now go to example.com
  • Open PSAT from devtools.
  • Go to explorable explanation tab.
  • As animation progresses, user should be able to see tables switching with the relevant data.

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #857

@mayan-000 mayan-000 changed the title Feature Feature: Add tables to PA EE Dec 11, 2024
amovar18 and others added 18 commits December 11, 2024 17:24
@amovar18
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
a36d4a2 
…l into feat/pa-ee-tables
@amovar18
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
93f10f1 
…l into feat/pa-ee-tables
@amovar18
Integrate tables with ee.
d38b186
@amovar18
Pause drawing of the flow.
2bbcfd7
@amovar18
Add setCurrentSite and more constants to stop breakage.
2a3c36e
@amovar18
Show formatted data.
b22a3fc
@amovar18
Add switching mechanism.
58c846b
@amovar18
Add tab switching to interest groups.
f86965b 
Remove console and use to UTC string.
@amovar18
Add jest.retryTimes(3) to flaky tests.
e154886
@amovar18
Fix lint error.
1edee39
@amovar18
Fix lint failure.
1baeb67
@amovar18
Fix CLI E2E tests.
00473da
@mayan-000
Add down icon to hide table tray and move resizable logic to table tr…
46123a7 
…ay component
@mayan-000
Add info panel for showing data
9554964
@amovar18
Generate synthetic auction event.
4743a49
@amovar18
Add event times
a21b16d
@amovar18
Merge branch 'feat/pa-ee-tables' of github.com:GoogleChromeLabs/ps-an…
5e986ba 
…alysis-tool into feat/pa-ee-tables
@amovar18
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
76bbbc2 
…l into feat/pa-ee-tables
@amovar18 amovar18 requested a review from mohdsayed December 16, 2024 11:38
@amovar18 amovar18 marked this pull request as ready for review December 16, 2024 11:38
@mohdsayed mohdsayed added this to the v1.0 milestone Dec 18, 2024
@mohdsayed mohdsayed merged commit 5afed08 into develop Dec 20, 2024
6 checks passed
@mohdsayed mohdsayed deleted the feat/pa-ee-tables branch December 20, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mayan-000 @mohdsayed @amovar18