Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping categories under personalization and security to Functional #891

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fellyph
Copy link
Collaborator

@fellyph fellyph commented Dec 11, 2024

Description

This pull request maps the cookies under the categories of personalization and security to functional, fixing issue #889.

Relevant Technical Choices

The 27 cookies categorized as personalization and security from the cookie database were listed as uncategorized when they were listed on the cookie database. This pull request changes the script update-cookie-db.cjs responsible for reading the cookies from the cookie database and converting it into JSON format. The change maps the categories security and personalization as Functional to not impact the current categorization.

Testing Instructions

  1. Pull the branch fix/security-personalization-categories
  2. Run the command npm run cookie-db:update to update the cookie database
  3. Build the project npm run build:all
  4. Navigate to globo.com
  5. Open the cookie table at the privacy sandbox tab on DevTools
  6. Filter the cookies for third-party and search the __eoi cookie

Additional Information:

Screenshot/Screencast

Before:
Screenshot 2024-12-11 at 09 39 29

After:
Screenshot 2024-12-11 at 15 49 35


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant