Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add filters to stories #894

Merged
merged 21 commits into from
Dec 13, 2024
Merged

Feature: Add filters to stories #894

merged 21 commits into from
Dec 13, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Dec 13, 2024 •
edited
Loading

Description

This PR creates dumb components (TopBar, Chips, FiltersSidebar) from Table components so they can be reused across other panels.
The stories panel has implemented these components with dummy data.
Also refactoring the code for the table to include these new dumb components has been done.

Relevant Technical Choices

Testing Instructions

  • Open the PSAT panel and go to the Stories panel.
  • A Search bar, Filter sidebar, and Chips bar should be present.
  • The components should be working but no effect on data for now.
  • Now move to the Cookies Panel, landing and tables both individually.
  • Test the functionality of filters, it should be working the same as compared to the develop branch.

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@amovar18 amovar18 marked this pull request as ready for review December 13, 2024 12:02
mohdsayed
mohdsayed reviewed Dec 13, 2024
View reviewed changes
packages/extension/src/view/devtools/components/webStories/contentPanel.tsx
count={0} // TODO: Add count
>
<div className="flex justify-between min-w-28">
<p>Sort by:</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be label?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, key is the object access key.
Eg. analytics.category in Cookies table

mohdsayed
mohdsayed reviewed Dec 13, 2024
View reviewed changes
packages/extension/src/view/devtools/stateProviders/stories/context.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the word webStories instead of stories to avoid confusion from the storybook stories

mohdsayed
mohdsayed reviewed Dec 13, 2024
View reviewed changes
packages/extension/src/view/devtools/stateProviders/stories/useStories.ts
@@ -0,0 +1,40 @@
/*
* Copyright 2023 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste?

@mohdsayed mohdsayed merged commit 3f4ed2b into release/v0.13.0 Dec 13, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/stories-filters branch December 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayan-000 @mohdsayed @amovar18