Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Introduce AdUnit and Bids tabs to explorable explanation in EE. #905

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jan 1, 2025

Description

This PR aims to add AdUnit and Bids Tabs to explorable explanation in PA

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run build:ext.
  • Now go to example.com
  • Open PSAT from DevTools.
  • Go to explorable explanation tab.
  • As animation progresses, user should be able to see tables switching with the relevant data.(Sites marking which start with adv will show data in interest group tab and sites marking which start with pub will show auction tab).
  • As animation progresses from the next circle, the data of the next circle should be shown in the respective tabs.

Additional Information:

  • The bids and auction data is shown in the table below when the flow reaches a circle marked as pub1.com or pub2.com.
  • The data should disappear when the flow moves on from pub1.com or pub2.com.

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 self-assigned this Jan 1, 2025
@amovar18 amovar18 added this to the v1.0 milestone Jan 1, 2025
@amovar18 amovar18 changed the base branch from main to develop January 1, 2025 10:44
@mayan-000 mayan-000 marked this pull request as ready for review January 1, 2025 15:31
@amovar18 amovar18 requested a review from mohdsayed January 2, 2025 06:16
@mohdsayed
Copy link
Collaborator

  1. Please reduce the font size of the tabs, it doesn't match with rest of the font sizes in the bottom table.
image

As animation progresses, user should be able to see tables switching with the relevant data.

When are we supposed to see this populated, and when should it disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants