Skip to content

Commit

Permalink
Update default functions framework versions
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 671613309
Change-Id: Ie058e5c7b4107a30d3189e473dcab9b080c3999c
  • Loading branch information
GCP Buildpacks Team authored and copybara-github committed Sep 6, 2024
1 parent 55cf12a commit 714a31c
Show file tree
Hide file tree
Showing 9 changed files with 1,925 additions and 382 deletions.
12 changes: 6 additions & 6 deletions builders/nodejs/acceptance/gcf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func TestAcceptance(t *testing.T) {
Name: "function without package",
App: "no_package",
Labels: map[string]string{
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.2.0\",\"injected\":true}",
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.4.2\",\"injected\":true}",
},
},
{
Expand All @@ -73,7 +73,7 @@ func TestAcceptance(t *testing.T) {
MustNotUse: []string{yarn},
EnableCacheTest: true,
Labels: map[string]string{
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.2.0\",\"injected\":true}",
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.4.2\",\"injected\":true}",
},
},
{
Expand Down Expand Up @@ -105,7 +105,7 @@ func TestAcceptance(t *testing.T) {
MustNotUse: []string{yarn},
EnableCacheTest: true,
Labels: map[string]string{
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.2.0\",\"injected\":true}",
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.4.2\",\"injected\":true}",
},
},
{
Expand All @@ -114,7 +114,7 @@ func TestAcceptance(t *testing.T) {
MustUse: []string{yarn},
MustNotUse: []string{npm},
Labels: map[string]string{
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.2.0\",\"injected\":true}",
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.4.2\",\"injected\":true}",
},
},
{
Expand All @@ -123,7 +123,7 @@ func TestAcceptance(t *testing.T) {
MustUse: []string{npm},
MustNotUse: []string{yarn},
Labels: map[string]string{
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.2.0\",\"injected\":true}",
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.4.2\",\"injected\":true}",
},
},
{
Expand All @@ -133,7 +133,7 @@ func TestAcceptance(t *testing.T) {
MustUse: []string{yarn},
MustNotUse: []string{npm},
Labels: map[string]string{
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.2.0\",\"injected\":true}",
"google.functions-framework-version": "{\"runtime\":\"nodejs\",\"version\":\"3.4.2\",\"injected\":true}",
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion builders/python/acceptance/gcf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func TestFailures(t *testing.T) {
},
{
App: "fail_broken_dependencies",
MustMatch: `functions-framework .* has requirement flask<3\.0,>=1\.0, but you have flask 0\.12\.5`,
MustMatch: `functions-framework .* has requirement flask.*,>=.*, but you have flask 0\.12\.5`,
// this is only a warning in python37
VersionInclusionConstraint: ">= 3.8.0",
},
Expand Down
2 changes: 2 additions & 0 deletions cmd/nodejs/functions_framework/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ licenses(["notice"])
buildpack(
name = "functions_framework",
srcs = [
"converter/without-framework-compat/package.json",
"converter/without-framework-compat/package-lock.json",
"converter/without-framework/package.json",
"converter/without-framework/package-lock.json",
],
Expand Down
Loading

0 comments on commit 714a31c

Please sign in to comment.