Add metrics for npm vendor dependencies

PiperOrigin-RevId: 569031543 Change-Id: I31b8b2fcd1a487b9690d2b55cce18ac1a8b3ac29
GoogleCloudPlatform · Sep 28, 2023 · bfe003f · bfe003f
1 parent df4a28b
commit bfe003f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/cmd/nodejs/npm/BUILD.bazel b/cmd/nodejs/npm/BUILD.bazel
@@ -27,6 +27,7 @@ go_binary(
     ],
     deps = [
         "//pkg/ar",
+        "//pkg/buildermetrics",
         "//pkg/cache",
         "//pkg/devmode",
         "//pkg/gcpbuildpack",

diff --git a/cmd/nodejs/npm/main.go b/cmd/nodejs/npm/main.go
@@ -23,6 +23,7 @@ import (
 	"strings"
 
 	"github.com/GoogleCloudPlatform/buildpacks/pkg/ar"
+	"github.com/GoogleCloudPlatform/buildpacks/pkg/buildermetrics"
 	"github.com/GoogleCloudPlatform/buildpacks/pkg/cache"
 	"github.com/GoogleCloudPlatform/buildpacks/pkg/devmode"
 	gcp "github.com/GoogleCloudPlatform/buildpacks/pkg/gcpbuildpack"
@@ -54,6 +55,10 @@ func buildFn(ctx *gcp.Context) error {
 		return fmt.Errorf("creating layer: %w", err)
 	}
 	nm := filepath.Join(ml.Path, "node_modules")
+	if nmExists, _ := ctx.FileExists("node_modules"); nmExists {
+		buildermetrics.GlobalBuilderMetrics().GetCounter(buildermetrics.NpmNodeModulesCounterID).Increment(1)
+
+	}
 	vendorNpmDeps := nodejs.IsUsingVendoredDependencies()
 	if !vendorNpmDeps {
 		if err := ctx.RemoveAll("node_modules"); err != nil {
@@ -95,6 +100,7 @@ func buildFn(ctx *gcp.Context) error {
 	}
 
 	if vendorNpmDeps {
+		buildermetrics.GlobalBuilderMetrics().GetCounter(buildermetrics.NpmVendorDependenciesCounterID).Increment(1)
 		if _, err := ctx.Exec([]string{"npm", "rebuild"}, gcp.WithEnv("NODE_ENV="+buildNodeEnv), gcp.WithUserAttribution); err != nil {
 			return err
 		}

diff --git a/pkg/buildermetrics/counterids.go b/pkg/buildermetrics/counterids.go
@@ -39,6 +39,8 @@ const (
 	NpmBuildUsageCounterID                CounterID = "3"
 	NpmGoogleNodeRunScriptsUsageCounterID CounterID = "4"
 	PipVendorDependenciesCounterID        CounterID = "5"
+	NpmNodeModulesCounterID               CounterID = "6"
+	NpmVendorDependenciesCounterID        CounterID = "7"
 )
 
 var (
@@ -63,6 +65,14 @@ var (
 			"vendor_pip_dependencies_uses",
 			"The number of times GOOGLE_VENDOR_PIP_DEPENDENCIES is used by developers",
 		},
+		NpmNodeModulesCounterID: Descriptor{
+			"npm_node_modules_uses",
+			"The number of times node_modules directory exist in source code",
+		},
+		NpmVendorDependenciesCounterID: Descriptor{
+			"vendor_npm_dependencies_uses",
+			"The number of times GOOGLE_VENDOR_NPM_DEPENDENCIES is used by developers",
+		},
 	}
 )