Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kms-solutions repo into CFT #2238

Merged

Conversation

romanini-ciandt
Copy link
Contributor

@romanini-ciandt romanini-ciandt commented Mar 28, 2024

The goal of this PR is to link CFT with kms-solutions repo

@daniel-cit
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Mar 28, 2024
@apeabody apeabody requested a review from tdbhacks March 28, 2024 18:41
Copy link
Member

@tdbhacks tdbhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

infra/terraform/test-org/org/locals.tf Outdated Show resolved Hide resolved
@apeabody
Copy link
Collaborator

Ideally GoogleCloudPlatform/kms-solutions#2 will be merged first

@romanini-ciandt
Copy link
Contributor Author

@apeabody GoogleCloudPlatform/kms-solutions#2 is now merged!

@apeabody
Copy link
Collaborator

apeabody commented Apr 1, 2024

applied

@apeabody apeabody merged commit df150e2 into GoogleCloudPlatform:master Apr 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants