chore: Update all Functions samples to .NET 8.0 #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
added
the
do not merge
product-auto-label
bot
added
the
samples
There was a problem hiding this comment.
LGTM, but there's a failure because this one also needs to be updated: https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/main/functions/responsestreaming/StreamBigQuery.Tests/StreamBigQuery.Tests.csproj
|
Whoops - how did we end up with a .NET 7 sample? Urgh. Will fix that tomorrow. |
jskeet
force-pushed
the
functions-dotnet8
branch
from
bccfc12 to
408d5e4
Compare
|
Updated the last file, so hopefully it'll go green... |
amanda-tarafa
previously approved these changes
Jul 17, 2024
amanda-tarafa
added a commit
that referenced
this pull request
Jul 22, 2024
This will be upgraded to .NET 8 in #2729 but there are still some documentation aspects that need to be cleared out before that can be merged. And this sample has been failing since we updated CI to support .NET 6 and .NET 8 only.
amanda-tarafa
added a commit
that referenced
this pull request
Jul 22, 2024
This will be upgraded to .NET 8 in #2729 but there are still some documentation aspects that need to be cleared out before that can be merged. And this sample has been failing since we updated CI to support .NET 6 and .NET 8 only.
meteatamel
pushed a commit
to meteatamel/dotnet-docs-samples
that referenced
this pull request
Aug 5, 2024
This will be upgraded to .NET 8 in GoogleCloudPlatform#2729 but there are still some documentation aspects that need to be cleared out before that can be merged. And this sample has been failing since we updated CI to support .NET 6 and .NET 8 only.
We need to make sure documentation is updated accordingly to specify gen2 and the right runtime.
jskeet
force-pushed
the
functions-dotnet8
branch
from
408d5e4 to
a624761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure documentation is updated accordingly to specify gen2 and the right runtime. (Hence the do-not-merge label.)