Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dry-run VPC SC implementation #25

Merged
merged 6 commits into from
May 20, 2024

Conversation

romanini-ciandt
Copy link
Collaborator

@romanini-ciandt romanini-ciandt commented May 10, 2024

This PR introduces VPC Service Control resources in order to make the automation more secure.

@romanini-ciandt romanini-ciandt changed the title Add dry-run VPC SC implementation feat: Add dry-run VPC SC implementation May 10, 2024
@romanini-ciandt romanini-ciandt marked this pull request as ready for review May 10, 2024 13:41
@romanini-ciandt romanini-ciandt requested review from tdbhacks and a team as code owners May 10, 2024 13:41
@tdbhacks
Copy link
Member

LGTM, thanks for the security improvement Leo! Let's wait for @rishamchokshi to approve too.

@rishamchokshi
Copy link
Collaborator

LGTM

@tdbhacks tdbhacks merged commit c45ff7f into GoogleCloudPlatform:main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants