Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc to 1.69.2 to fix dependency problem #953

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

quentinmit
Copy link
Member

grpc briefly had a separate module for
google.golang.org/grpc/stats/opentelemetry; because the module was now deleted, Go can't properly resolve dependencies with errors such as:

go: github.com/GoogleCloudPlatform/opentelemetry-operations-collector/service imports
        github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter imports
        github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector imports
        google.golang.org/grpc/stats/opentelemetry: ambiguous import: found package google.golang.org/grpc/stats/opentelemetry in multiple modules:
        google.golang.org/grpc v1.69.2 (/usr/local/google/home/quentin/go/pkg/mod/google.golang.org/grpc@v1.69.2/stats/opentelemetry)
        google.golang.org/grpc/stats/opentelemetry v0.0.0-20240702152247-2da976983bbb (/usr/local/google/home/quentin/go/pkg/mod/google.golang.org/grpc/stats/opentelemetry@v0.0.0-20240702152247-2da976983bbb)

grpc briefly had a separate module for
google.golang.org/grpc/stats/opentelemetry; because the module was now
deleted, Go can't properly resolve dependencies with errors such as:

go: github.com/GoogleCloudPlatform/opentelemetry-operations-collector/service imports
        github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter imports
        github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector imports
        google.golang.org/grpc/stats/opentelemetry: ambiguous import: found package google.golang.org/grpc/stats/opentelemetry in multiple modules:
        google.golang.org/grpc v1.69.2 (/usr/local/google/home/quentin/go/pkg/mod/google.golang.org/grpc@v1.69.2/stats/opentelemetry)
        google.golang.org/grpc/stats/opentelemetry v0.0.0-20240702152247-2da976983bbb (/usr/local/google/home/quentin/go/pkg/mod/google.golang.org/grpc/stats/opentelemetry@v0.0.0-20240702152247-2da976983bbb)
@dashpole dashpole merged commit 4d7cd40 into GoogleCloudPlatform:main Jan 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants