Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider news read if news.version > current version #3734

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Tejada-Omar
Copy link
Contributor

Avoids two installations of taskwarrior with differing versions from constantly nagging and rewriting news.version

Note that this potentially isn't the best behavior across major versions updates, although in that case task news doesn't display any new items anyways so it's probably fine

Avoids two installations of taskwarrior with differing versions from
constantly nagging and rewriting `news.version`
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to think this functionality is more trouble than it's worth. But this patch is good!

@djmitche djmitche merged commit 3bf0200 into GothenburgBitFactory:develop Dec 23, 2024
16 checks passed
@Tejada-Omar Tejada-Omar deleted the news-nag branch December 28, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants