Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git log in CMakeLists.txt to not include potential signatures #3742

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

grasegger
Copy link
Contributor

Hey there,

today I tried building taskwarrior from the stable branch, but I got error messages about missing quotes in the commit.h file. Turns out, that capturing the git log output for the commit ref, my git configuration added output about the trust of the commits (that are in signed).

I have added the command line option to hide potential signatures to the CMakeLists.txt, and the commit.h was formatted correct again.

Before my change:

/* commit.h.in. Creates commit.h during a cmake run */

/* git information */
#define COMMIT "gpg: Signature made Thu 19 Dec 2024 04:57:43 PM CET
gpg:                using RSA key B5690EEEBB952194
gpg: Good signature from "GitHub <noreply@github.com>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 9684 79A1 AFF9 27E3 7D1A  566B B569 0EEE BB95 2194
1ee69ea21"

After my change:

/* commit.h.in. Creates commit.h during a cmake run */

/* git information */
#define COMMIT "1ee69ea21"

@djmitche djmitche added the build-system Related to build system (Cmake) label Dec 31, 2024
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you!

@djmitche djmitche merged commit 630585d into GothenburgBitFactory:develop Dec 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system Related to build system (Cmake)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants