Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Entry in Lightbox: Redirect to URL doesn't parse Merge Tags #2220

Open
rafaehlers opened this issue Nov 26, 2024 · 4 comments
Open

Edit Entry in Lightbox: Redirect to URL doesn't parse Merge Tags #2220

rafaehlers opened this issue Nov 26, 2024 · 4 comments
Assignees
@rafaehlers @mrcasual
Labels
Bug

Comments

@rafaehlers
Copy link
Contributor

image

After editing an entry that has been opened inside a lightbox, if there's a Merge Tag in the "Edit Entry Redirect URL" field for the "Redirect to URL" setting, then that Merge Tag won't be parsed:

image

Tested on GV 2.32
@rafaehlers rafaehlers added the Bug label Nov 26, 2024
@rafaehlers
Copy link
Contributor Author

https://secure.helpscout.net/conversation/2657184499/55977

mrcasual added a commit that referenced this issue Nov 26, 2024
@mrcasual
Process merge tags in redirect URLs inside the lightbox (#2220)
d8bc060
@mrcasual mrcasual mentioned this issue Nov 26, 2024
Merged
@mrcasual mrcasual self-assigned this Nov 26, 2024
mrcasual added a commit that referenced this issue Nov 26, 2024
@mrcasual
Process merge tags in redirect URLs inside the lightbox (#2220)
be157aa
mrcasual added a commit that referenced this issue Nov 26, 2024
@mrcasual
Process merge tags in redirect URLs inside the lightbox (#2220)
04c3154
mrcasual added a commit that referenced this issue Nov 26, 2024
@mrcasual
Process merge tags in redirect URLs inside the lightbox (#2220)
14f7b50
mrcasual added a commit that referenced this issue Nov 27, 2024
@mrcasual
Process merge tags in redirect URLs inside the lightbox (#2221)
790fb55 
This implements #2220.

💾 [Build
file](https://www.dropbox.com/scl/fi/yfoqw0r98dn0gux0ydw09/gravityview-2.32-14f7b50a4.zip?rlkey=60scz8lo9tb73q3mjujjc366m&dl=1)
(14f7b50).
@rafaehlers
Copy link
Contributor Author

@mrcasual, we need an adjustment here: the merge tags are not parsed on the redirect message:

image

Monosnap.Video.2024-12-04.15.1.mp4

@rafaehlers
Copy link
Contributor Author

https://secure.helpscout.net/conversation/2783729071/59756

mrcasual added a commit that referenced this issue Dec 7, 2024
@mrcasual
Display the correct redirectio URL after editing an entry
582cc28 
Ref: #2220 (comment)
@mrcasual
Copy link
Collaborator

mrcasual commented Dec 7, 2024

@mrcasual, we need an adjustment here: the merge tags are not parsed on the redirect message

@rafaehlers, fixed in 582cc28. FYI: (1) this is not a lightbox issue, (2) this has been an issue since 2018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaehlers rafaehlers

@mrcasual mrcasual

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaehlers @mrcasual