Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process merge tags in redirect URLs inside the lightbox #2221

Merged

Conversation

mrcasual
Copy link
Collaborator

@mrcasual mrcasual commented Nov 26, 2024

This implements #2220.

💾 Build file (14f7b50).

@mrcasual mrcasual requested a review from rafaehlers November 26, 2024 20:41
@mrcasual mrcasual self-assigned this Nov 26, 2024
@mrcasual mrcasual requested a review from Mwalek November 26, 2024 20:42
@mrcasual
Copy link
Collaborator Author

@Mwalek (or @rafaehlers), please test.

@mrcasual mrcasual force-pushed the issue/2220-merge-tags-in-redirect-urls-inside-lightbox branch 2 times, most recently from be157aa to 04c3154 Compare November 26, 2024 20:45
@mrcasual mrcasual force-pushed the issue/2220-merge-tags-in-redirect-urls-inside-lightbox branch from 04c3154 to 14f7b50 Compare November 26, 2024 20:48
Copy link
Contributor

@rafaehlers rafaehlers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@mrcasual mrcasual merged commit 790fb55 into develop Nov 27, 2024
1 check passed
@rafaehlers
Copy link
Contributor

We need another look because of this: #2220 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants