Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(material_integrations): use POO to manage integrations with Material theme framework #335

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Nov 30, 2024

Related to #250

@github-actions github-actions bot added enhancement New feature or request quality Tests, project resiliency, etc. labels Nov 30, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 72.83951% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (c2ff32c) to head (c36dd95).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
..._plugin/integrations/theme_material_blog_plugin.py 71.05% 8 Missing and 3 partials ⚠️
...ocs_rss_plugin/integrations/theme_material_base.py 81.81% 5 Missing and 1 partial ⚠️
...lugin/integrations/theme_material_social_plugin.py 50.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   79.57%   79.91%   +0.33%     
==========================================
  Files           9       11       +2     
  Lines         666      707      +41     
  Branches      117      121       +4     
==========================================
+ Hits          530      565      +35     
- Misses         94       99       +5     
- Partials       42       43       +1     
Flag Coverage Δ
unittests 79.91% <72.83%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/integrations/theme_material_social_plugin.py 74.59% <50.00%> (+2.22%) ⬆️
...ocs_rss_plugin/integrations/theme_material_base.py 81.81% <81.81%> (ø)
..._plugin/integrations/theme_material_blog_plugin.py 71.05% <71.05%> (ø)

@Guts Guts force-pushed the feature/add-support-for-material-blog-authors branch from acf24f0 to b12a481 Compare December 2, 2024 11:19
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Guts Guts self-assigned this Dec 2, 2024
@Guts Guts merged commit 6059ba7 into main Dec 2, 2024
11 checks passed
@Guts Guts deleted the feature/add-support-for-material-blog-authors branch December 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support defining a mapping between author identifier and the author in the feed
1 participant