Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/Tech] Fixup Snap publishing in build-base workflow #3223

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

CommandMC
Copy link
Collaborator

Of course, the one thing I can't test locally breaks
The workflow tried to access snapcraftEdgeId, but the secret in question is named snapcraftIdEdge


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

This prevents all builds from getting cancelled if one fails
@CommandMC CommandMC self-assigned this Nov 8, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, S!$% happens 🤷🏽

@flavioislima flavioislima merged commit f1db3d6 into main Nov 21, 2023
13 checks passed
@flavioislima flavioislima deleted the fix/snap-publish branch November 21, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants