Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalisation of Heroic in GlobalState.tsx #4218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LenaWil
Copy link
Contributor

@LenaWil LenaWil commented Dec 28, 2024

I noticed it while translating.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

I noticed it while translating.
@LenaWil
Copy link
Contributor Author

LenaWil commented Dec 28, 2024

Am I stupid, or should e2e not fail?

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 28, 2024
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to run pnpm i18n so it updates the locale json file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants